Broke the methods apart to make it cleaner if the user wants more meshing control #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
reviewed
Jan 29, 2025
shimwell
reviewed
Jan 29, 2025
shimwell
reviewed
Jan 29, 2025
Collaborator
|
This looks like a good approach to me. I can close #5 |
Member
Author
|
@shimwell Did you man to close this PR too? |
Fix gmsh name Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
Member
Author
|
@shimwell I have added an example of how to use |
shimwell
approved these changes
Jan 29, 2025
Collaborator
sorry that was my mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shimwell Please review this as an alternative to #5 and let me know what you think